Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NAPI instead of V8 #11

Closed
maierfelix opened this issue Feb 13, 2019 · 3 comments
Closed

Use NAPI instead of V8 #11

maierfelix opened this issue Feb 13, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@maierfelix
Copy link
Owner

maierfelix commented Feb 13, 2019

This would allow users to install nvk without the need to download the SDK and compile the bindings. The need of installing Lunar's Vulkan runtime could also be removed by just shipping the runtime files with the binaries.

Edit: this branch contains all necessary conversions, nearly ready to be merged

@maierfelix maierfelix added the enhancement New feature or request label Feb 13, 2019
@maierfelix
Copy link
Owner Author

maierfelix commented Feb 14, 2019

@Reon90 NAPI conversions are landed into master with version 0.2.5 and commit c4d484d, could you test your RT project if it's still working?

Just reinstall nvk in your project with:

npm uninstall nvk
npm install nvk

@Reon90
Copy link

Reon90 commented Feb 14, 2019

@maierfelix yes it's working.

@maierfelix
Copy link
Owner Author

great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants