Nextcloud install can't be run twice

[b-k]

My nextcloud installation failed, so I tried running the setup twice, which can't work. It fails because this line in setup/nextcloud.sh...

echo "ALTER TABLE oc_flow_operations ADD COLUMN entity VARCHAR;" | sqlite3 $STORAGE_ROOT/owncloud/owncloud.db

...will fail the second time it runs, because you can't add a column twice. You'll get Error: near line 1: duplicate column name: entity.

That means even if I fix whatever is broken with the nextcloud update, I'm not going to be able to get past this line.

One fix might be to check whether the table is already altered, via, e.g.,

sqlite3 $STORAGE_ROOT/owncloud/owncloud.db ".schema" | grep 'oc_flow_operations.*entity'

and skipping the alter table step if grep returns with a status of 0.

[jvolkenant]

Since it exits with a non zero exit code, bash's +x is exiting the run.

You're right, we can search it based on .schema, (or even PRAGMA table_info(oc_flow_operations)), we won't really do anything if it fails, we can just assume it's always successful too.

root@testjammy:~/mailinabox# echo "ALTER TABLE oc_flow_operations ADD COLUMN entity VARCHAR;" | sqlite3 $STORAGE_ROOT/owncloud/owncloud.db
Error: near line 1: duplicate column name: entity
root@testjammy:~/mailinabox# echo $?
1
root@testjammy:~/mailinabox# (echo "ALTER TABLE oc_flow_operations ADD COLUMN entity VARCHAR;" | sqlite3 $STORAGE_ROOT/owncloud/owncloud.db 2>/dev/null) || true
root@testjammy:~/mailinabox# echo $?
0