Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "sender" consumer to handle SendEmail AWS action (send email to a subscriber) #995

Closed
FilipNikolovski opened this issue Jan 13, 2021 · 8 comments
Labels
enhancement go Pull requests that update Go code
Projects
Milestone

Comments

@FilipNikolovski
Copy link
Collaborator

FilipNikolovski commented Jan 13, 2021

Draft design of the flow:

sender

Update the image if there are any changes, and add retries on this link

The sender consumer will have the task to send an email using the SendEmail AWS action. The message that is sent to this channel will contain all of the necessary information required to send an email - a destination email, from email, message, user's ses keys, and a unique id (for idempotency purposes).

After a successful send, we store the message in the log along with the message ID.

The consumer needs to handle idempotency (duplicate messages should be dropped) in order to avoid sending an email multiple times to a subscriber.

@FilipNikolovski FilipNikolovski added enhancement go Pull requests that update Go code labels Jan 13, 2021
@FilipNikolovski FilipNikolovski added this to the v1.0 milestone Jan 13, 2021
@FilipNikolovski FilipNikolovski added this to To do in Mailbadger via automation Jan 13, 2021
@gudgl
Copy link
Contributor

gudgl commented Jan 26, 2021

@FilipNikolovski can you confirm that this is our case for sending mails https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/ses-example-send-email.html

@gudgl
Copy link
Contributor

gudgl commented Jan 26, 2021

1h

@FilipNikolovski
Copy link
Collaborator Author

@FilipNikolovski can you confirm that this is our case for sending mails https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/ses-example-send-email.html

Yes this is the one, we also need to add the ConfigurationSetName in the params and I think that's it.

@gudgl
Copy link
Contributor

gudgl commented Jan 26, 2021

3h

@gudgl
Copy link
Contributor

gudgl commented Jan 29, 2021

Update version of sender flow

sender

https://excalidraw.com/#json=6261970302926848,eVpgJ_S7gvhgarju2IBqyg

@gudgl
Copy link
Contributor

gudgl commented Feb 2, 2021

4h

@gudgl
Copy link
Contributor

gudgl commented Feb 3, 2021

1h

@gudgl
Copy link
Contributor

gudgl commented Feb 5, 2021

1h (yesterday + today)

@FilipNikolovski FilipNikolovski moved this from To do to In progress in Mailbadger Feb 5, 2021
Mailbadger automation moved this from In progress to Done Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement go Pull requests that update Go code
Projects
Mailbadger
  
Done
Development

No branches or pull requests

2 participants