New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending messages without a subject #65
Comments
Hi @damien! If mailboxer is somehow great is for people like you submitting new ideas ;) There is no particular reason for subjet to be required, indeed it seems a great bug if you don't need to use them. We never faced this problem, so we never came up with a solution. The answers for 1 and 2 are NO. There should be no problem with Mailboxer and, as far as I remember, no other implication is present. I will happily accept this patch, but as long as this will require a new minor version because of the change, I think I should be a bit deeper. The change from You did more than enough by opening this issue and letting us know the bug, but do you feel brave enough to help us by submitting this change? Thanks, many many thanks! |
@Roendal I was considering doing just that! I just wanted to make sure it would be an acceptable patch before I started any work. I'm tight on time now, but I'll most likely be working on this tomorrow evening and/or this weekend. I'll update this issue as I make progress. |
Take the time you need @damien! Thanks again :) |
Just an update; I'm currently working on this and it's turning out to be a bit more involved than I had originally anticipated. I'm doing a lot of updating of the test suite to get it green after changing most of the function signatures across the app. I'll definitely need a solid code review before this patch gets merged. Also worth noting: I've been updating a lot of the inline YARD documentation for my own benefit. Thus far most of the functions I've touched now have documentation on the input paramaters and return types. |
Thanks for the update and good luck with the challenge. It's indeed a really great one! You are doing a superb work @damien! Take the time you need! |
Hello ! I have the same problem. I want that the subject is optional, I tried this : class Conversation < ActiveRecord::Base attr_accessible :subject if Mailboxer.protected_attributes? has_many :messages, :dependent => :destroy has_many :receipts, :through => :messages #TODO Virer l'obligation d un sujet #validates_presence_of :subject messageable.rb def send_message(recipients, msg_body, subject='', sanitize_text=true, attachment=nil, message_timestamp = Time.now) convo = Conversation.new({:subject => subject}) convo.created_at = message_timestamp convo.updated_at = message_timestamp message = messages.new({:body => msg_body, :subject => subject, :attachment => attachment}) But when I try : Nothing happend.. What did I miss? Can I accept a mail without subject ? Thank you for your help ! |
The |
Was this change ever submitted (ability to reply without a subject) ? |
Anyone reading – I opt for setting the subject to ¯_(ツ)_/¯ |
Hey guys!
First off, thanks for mailboxer. Great piece of work!
That being said, is there any particular reason why a
subject
is required to send a message? I have a requirement to send messages without requiring a subject and ended up overriding the defaultsend_message
method like so:Here's what I'm wondering:
send_message
?The text was updated successfully, but these errors were encountered: