Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include encoding type when returning the public key #311

Closed
robdefeo opened this issue Oct 20, 2019 · 0 comments
Closed

Include encoding type when returning the public key #311

robdefeo opened this issue Oct 20, 2019 · 0 comments

Comments

@robdefeo
Copy link
Member

Is your feature request related to a problem? Please describe.
A public key can be encoded in various methods, currently it is based in the protocol. This is not clear to the caller what encoding is used and it is not future proof.

Describe the solution you'd like
Including the encoding used for public as per #310

{
    "public_key": "0x369bb60e6d99e30144e8fab8087bd7d171ba7b5dbf691b87319584b3d6c1892c"
    "public_key_encoding": "hex/0x-prefix"
}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@robdefeo robdefeo changed the title Include encoding-type when returning the public key Include encoding type when returning the public key Oct 20, 2019
@robdefeo robdefeo added this to Done in protocol/substrate Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant