Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minified version of script #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martey
Copy link

@martey martey commented May 6, 2022

Do not include minified version of script as part of source code and remove pre-commit hook. Because minified code can be easily generated from the unminified code, committing two codes of the script is an anti-pattern.

Do not include minified version of script as part of source code and
remove pre-commit hook.  Because minified code can be easily generated
from the unminified code, committing two codes of the script is an
anti-pattern.
@ferreiro
Copy link

ferreiro commented Oct 22, 2022

Hey @martey , this library is no longer maintained, and agreed that keeping the minified is a bad practise.

I rewrote it entirely and update it for 2022 and onward: https://github.com/ZooTools/email-spell-checker

  • 💙 Written in TypeScript and removed jQuery
  • ✅ Fixed a couple of bugs like this or this
  • 🚀 Reduced bundle size to <2KB.

  • ✨ Update TLDs (69+) and added modern startup domains (like .io, .so, .xyz or .dev)
  • 🙏 Implemented suggestions that people made in this repo that were ignored.

Link: https://github.com/ZooTools/email-spell-checker

Come check it out and give it a ⭐️ for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants