Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v1.1.0 #78

Closed
wants to merge 1 commit into from
Closed

fix v1.1.0 #78

wants to merge 1 commit into from

Conversation

tomByrer
Copy link
Contributor

@tomByrer tomByrer commented Jun 9, 2014

No code changes, just "version": "1.1.0" in 3 JSON, & /src header comments
#76 (comment)

No code changes, just `"version": "1.1.0"` in 3 JSON, & /src header comments
mailcheck#76 (comment)
@weilu
Copy link
Contributor

weilu commented Jun 9, 2014

Interesting, it appears that src/mailcheck.js has the misinformation -- the comments in there should be changed to reflect the current version instead. 3ca5642

@tomByrer
Copy link
Contributor Author

tomByrer commented Jun 9, 2014

I have no idea what version it should be now. Seems you do, so perhaps you can fix this mess please?

@tomByrer tomByrer closed this Jun 9, 2014
@tomByrer tomByrer deleted the fix-v1.1.0 branch June 9, 2014 13:32
@tomByrer tomByrer mentioned this pull request Jun 9, 2014
@tomByrer
Copy link
Contributor Author

tomByrer commented Jun 9, 2014

This comment:

Removed backward compatibility with old mailcheck function signature.

Leads me to believe the change is API-breaking, so if you follow the SemVer standard, the version should really be 2.0.0.

@weilu
Copy link
Contributor

weilu commented Jun 10, 2014

@tomByrer Thanks for point that out. But that was more than two years ago. Moving forward, sticking with SemVer is the plan. Version in comments fixed in a5eeecc

@tomByrer
Copy link
Contributor Author

Cool, tyvm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants