-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCSTR() breaks providers lookups #70
Comments
It's not clear what this issue is about. Could you clarify? |
Set a breakpoint in |
When you're talking about code, it's more clear if you reference which file to look into. fillWithInfo() name is used at several locations. Regarding the issue itself: I don't think that's the reason of your issue. Keep investigating about your specific issue. MCSTR() does "" str "", which concatenate an empty string with str with an empty string. |
Reopen if that's really the issue and give more details. |
But it fails specifically for the providers dictionary because the JSON keys aren't made with MCSTR(), they're just parsed out into it. It works everywhere else because everywhere else uses MCSTR(). Here, these lines fail for every provider HashMap given to them: https://github.com/MailCore/mailcore2/blob/master/src/core/provider/MCMailProvider.cc#L62 And because they fail, every one of the folder lookup methods afterwards dereferences a NULL pointer and causes a fatal crash. |
If I replace those |
Therefore, that's an issue with String::uniquedStringWithUTF8Characters(). Could you try to apply that patch? diff --git a/src/core/basetypes/MCString.cc b/src/core/basetypes/MCString.cc static chash * uniquedStringHash = NULL; static void initUniquedStringHash()
|
Patch not broken by formatting is here: |
Yep, that patch solves it. Sorry I couldn't answer you earlier, I was integrating the framework and had to fix a ton of warnings before I could test anything. |
Fixed with b88d4be |
While we're at it, we should also synthesize the
identifier
propertyThe text was updated successfully, but these errors were encountered: