-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization to refactor this library #68
Comments
@thrawn01, These are some of the refactoring I am planning to add:
I am glad to open a PR in that respect if these changes seem necessary. Otherwise I can move them into a particular repo given I have the right permission. |
@thrawn01 I have pushed the modifications I am talking about here https://github.com/Tochemey/groupcache. |
These changes look very nice! A few points though.
|
@thrawn01 Thanks for the reply. I really appreciate it. |
@thrawn01 I am open to any option. I am here to contribute. |
Hi guys I am also interested in efforts to improve this lib. |
I am interested in a healthy groupcache ecosystem since I am currently using these: https://github.com/modernprogram/groupcache - fork from mailgun groupcache with support for user-controlled explicit state https://github.com/udhos/kubegroup - groupcache peer autodiscovery for k8s https://github.com/udhos/groupcache_exporter - export groupcache stats as prometheus metrics https://github.com/udhos/groupcache_oauth2 - store oauth2 client_credentials tokens in groupcache |
I've created a fork of this repo here https://github.com/groupcache/groupcache-go. I added the I would love to remove all the globals from the library in V3 such that we can run multiple instances of groupcache easily in testing. Here is what I'm thinking. I'm traveling for the next 2 weeks, and I don't always have access to internet/laptop so my responses might be delayed. I've created a new issue on the new repo where we can continue this conversation. |
Hello @thrawn01,
Thanks for the great piece of work of cloning the original version and enhancing it. I would like to know whether I can copy this library, refactor it and publish using the same license, however under a different module name.
The text was updated successfully, but these errors were encountered: