Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to send mails with only HTML content #28

Closed
MrTravisB opened this issue Dec 3, 2014 · 1 comment
Closed

Unable to send mails with only HTML content #28

MrTravisB opened this issue Dec 3, 2014 · 1 comment
Assignees
Labels

Comments

@MrTravisB
Copy link

Is there a specific reason why all attributes of a message are private and there are no accessor methods? Would be really helpful to be able to read these values. I'll submit a pull request if its welcome. Wanted to know the thinking behind this decision before doing it though.

Also, it seems that a text version of the message is required. Every time I try to send a message with just an HTML body I get "Message not valid". Another conscious decision? The Mailgun API doesn't suggest that this is required and to my knowledge it shouldn't be.

@mbanzon
Copy link
Collaborator

mbanzon commented Dec 8, 2014

I think that the original design was aimed at "fire and forget" - which made messages more short lived. I agree that accessor methods would be an improvement - a PR is welcome.

Regarding the required text message along with HTML - I quickly glanced at the documentation and it doesn't say anything about requiring text body along with HTML. Have you, by any change, tested this? If tests confirm proper behaviour with no text body a PR is also more than welcome.

@mbanzon mbanzon self-assigned this Jul 10, 2016
@mbanzon mbanzon modified the milestone: APIv3 Jul 10, 2016
@mbanzon mbanzon changed the title Accessor methods for a message Unable to send mails with only HTML content Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants