Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not extracting mail signatures for minor changes in email/signature. #27

Closed
juanjohn opened this issue Dec 10, 2014 · 1 comment
Closed

Comments

@juanjohn
Copy link

The following code which is the example works while running the library and returns signature as expected.

message = """Thanks Sasha, I can't go any higher and is why I limited it to the
homepage.

John Doe
via mobile"""

text, signature = signature.extract(message, sender='john.doe@example.com')

But when i make a minor edit as changing the sender name and his email id the signature returns "None". The following were values passed to signature.extract()

message = """
Hello ,
Thanks Sasha, I can't go any higher and is why I limited it to the
homepage.

Sam John
via mobile"""

text, signature = signature.extract(message, sender='samjohn@gmail.com')

Signature returned None for most of the messages that were tried.

@obukhov-sergey
Copy link
Member

Hi @juanjohn. In the 1st example 'john.doe@example.com' has a separator between first and last name. So the algo can detect that the sender's first name is John and his last name is Doe. First / Last name in the end of the message is a strong indicator that the line is signature. In your 2nd example the algo can't distract first / last name of the sender and there are not enough other indicators to detect a signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants