New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect signatures with long lines #68

Open
obukhov-sergey opened this Issue Nov 20, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@obukhov-sergey
Member

obukhov-sergey commented Nov 20, 2015

Generally signatures have short lines - no more than 60 characters but there is also a class of signatures that have long lines with long URLs, etc.

Example:

Some text

-- 


John Smith
Co-Founder and CEO
Xxxxxxxxx

mobile: 555.115.4274 | book a mtg
<http://example.com/soooooome/looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong/path?t=looooooooooooooooooooooooooooooooooooooooooooooooooooooooong>
 | @handle
<http://example.com/looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong/paaaaaaaaath?t=loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong>
 | linkedin
<http://example.com/loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong?t=loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong>
 | video
<http://example.com/looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong/paaath?t=loooooooooooooooong-parameeeeeeeeeeeeeeeeeeeeeeeeter-query-string>

Currently talon doesn't parse signatures like this

@jacobjlevine

This comment has been minimized.

Show comment
Hide comment
@jacobjlevine

jacobjlevine commented Jan 14, 2016

Seconded!

@mgwidmann

This comment has been minimized.

Show comment
Hide comment
@mgwidmann

mgwidmann Feb 18, 2016

Would this also apply to HTML based signatures (which are basically always longer than 60 characters)?

mgwidmann commented Feb 18, 2016

Would this also apply to HTML based signatures (which are basically always longer than 60 characters)?

@mgwidmann

This comment has been minimized.

Show comment
Hide comment
@mgwidmann

mgwidmann Feb 18, 2016

As an example, http://htmlsig.com puts the following disclaimer at the bottom of their email (which is common among businesses)

This e-mail message may contain confidential or legally privileged information and is intended only for the use of the intended recipient(s). Any unauthorized disclosure, dissemination, distribution, copying or the taking of any action in reliance on the information herein is prohibited. E-mails are not secure and cannot be guaranteed to be error free as they can be intercepted, amended, or contain viruses. Anyone who communicates with us by e-mail is deemed to have accepted these risks. Company Name is not responsible for errors or omissions in this message and denies any responsibility for any damage arising from the use of e-mail. Any opinion and other statement contained in this message and any attachment are solely those of the author and do not necessarily represent those of the company.

mgwidmann commented Feb 18, 2016

As an example, http://htmlsig.com puts the following disclaimer at the bottom of their email (which is common among businesses)

This e-mail message may contain confidential or legally privileged information and is intended only for the use of the intended recipient(s). Any unauthorized disclosure, dissemination, distribution, copying or the taking of any action in reliance on the information herein is prohibited. E-mails are not secure and cannot be guaranteed to be error free as they can be intercepted, amended, or contain viruses. Anyone who communicates with us by e-mail is deemed to have accepted these risks. Company Name is not responsible for errors or omissions in this message and denies any responsibility for any damage arising from the use of e-mail. Any opinion and other statement contained in this message and any attachment are solely those of the author and do not necessarily represent those of the company.

@codyolsen

This comment has been minimized.

Show comment
Hide comment
@codyolsen

codyolsen Nov 3, 2016

@obukhov-sergey What is currently limiting talon from parsing longer signatures?

codyolsen commented Nov 3, 2016

@obukhov-sergey What is currently limiting talon from parsing longer signatures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment