Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "type" attribute values of Tags in JSON data #464

Closed
bnvk opened this issue Feb 26, 2014 · 3 comments
Closed

Hide "type" attribute values of Tags in JSON data #464

bnvk opened this issue Feb 26, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@bnvk
Copy link
Contributor

bnvk commented Feb 26, 2014

In our initial Tag spec we had two attributes needed for proper flexibility for GUI:

  • type
  • display

Due to backend constraints "type" was omitted from the API for awhile, now it seems to be exist, but the values of type are uncertain to me- inbox, outbox, spam, etc... are all attributes of "type"

@bnvk bnvk added this to the Beta milestone Feb 26, 2014
@pagekite
Copy link
Contributor

This is a misunderstanding.

The "type" attribute was never meant for use by the UI. It is used internally by the Mailpile back-end to find the right tags for various functions without having to depend on hard-coded tag names. Please continue to ignore "type" completely in the front-end. If display and friends are insufficient for the front-end's needs, we will add more attributes.

@bnvk
Copy link
Contributor Author

bnvk commented Feb 26, 2014

Updated the title of issue. Since "type" is something you've claimed and are using in the backend it should not exist in the public JSON data as it's not usable for UI and confuses things!

@bnvk bnvk reopened this Feb 26, 2014
@pagekite
Copy link
Contributor

That won't work. Once you create a UI that allows users to edit the tags and their properties, you will need to see and be able to set this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants