Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document python version required (support for async def etc.) #5

Closed
nealmcb opened this issue Dec 13, 2017 · 2 comments
Closed

Document python version required (support for async def etc.) #5

nealmcb opened this issue Dec 13, 2017 · 2 comments

Comments

@nealmcb
Copy link

nealmcb commented Dec 13, 2017

I get this error, presumably because async def is not in Python 3.4:

..../deepspeech/lib/python3.4/site-packages/deepspeech_server/driver/http_driver.py", line 20
    async def on_post_data(request, path):
            ^
SyntaxError: invalid syntax

The README.md and setup.py files should indicate which version of Python is required.

@MainRo
Copy link
Owner

MainRo commented Dec 14, 2017

Yes python 3.5 is the minimal required version for now. I will document this.
If this is an issue for a lot of people I may replace them with "yield/coroutine" so that python 3.4 is supported.

@nealmcb
Copy link
Author

nealmcb commented Dec 15, 2017

Cool - thanks for using the setup.py python-requires too ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants