Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWP misreports LibreSSL/3.3.6 as lower than OpenSSL/1.1.0 #659

Open
nickcernis opened this issue Mar 25, 2024 · 0 comments
Open

MainWP misreports LibreSSL/3.3.6 as lower than OpenSSL/1.1.0 #659

nickcernis opened this issue Mar 25, 2024 · 0 comments

Comments

@nickcernis
Copy link

nickcernis commented Mar 25, 2024

Describe the bug
MainWP misreports LibreSSL/3.3.6 (default on new Macs, released March 15th 2022) as lower than OpenSSL 1.1.0 (released 25 August 2016) and in need of upgrade.

To Reproduce

  1. Run MainWP on a system that uses LibreSSL 3.3.6, such as a Mac running Local.
  2. Read the System Requirements Check during the setup wizard.

Expected behavior
There is no warning reading, "Your host needs to update OpenSSL to at least version 1.1.0…".

Screenshots
MainWP instead shows a warning.

Screenshot 2024-03-25 at 09 23 39

Desktop:

  • OS: macOS 14.4
  • Browser: n/a
  • Version: n/a

Additional context
Cause seems to be:

  • get_curl_ssl_version will return "(SecureTransport) LibreSSL/3.3.6" on systems with that version of LibreSSL like macOS 14.4.
  • A comparison is then made between the fixed minimum required value of OpenSSL/1.1.0 and the inferred SSL version, resulting in a version_compare call here of version_compare("(SecureTransport) LibreSSL/3.3.6", "OpenSSL/1.1.0", ">="); which will always return false due to the differing prefix.

Could be fixed by adjusting curl_sslcompare to account for LibreSSL, which was forked from OpenSSL in 2014 and could be in use on systems other than macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant