New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded pyyaml to version 6 #1019

Closed

HadiSDev wants to merge 2 commits into zenml-io:main from HadiSDev:main

HadiSDev commented Oct 27, 2022 •

edited

Describe changes

I just upgraded pyyaml to version 6.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
If I have added an integration, I have updated the integrations table and the corresponding website section.
I have added tests to cover my changes. (No tests needed)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above) package upgrade

AlexejPenner and others added 2 commits

October 25, 2022 14:26


          Fix broken links caused by updated (zenml-io#1002) (zenml-io#1003)

ab810a9

* Fix broken links due to new integration docs

* Fix broken links in core api docs

* Adjust the get_api_docs function to work with the new api docs

(cherry picked from commit f5ec3c8)


          Upgraded pyyaml to version 6

1791ae7

dnth self-assigned this

dnth added hacktoberfest-accepted enhancement labels

htahir1 requested a review from schustmi

October 27, 2022 15:50

Collaborator

schustmi commented Oct 28, 2022

Hi @HadiSDev, thanks for the PR! I'll need some time to thoroughly test this as some of our ZenML integrations might have dependencies on older versions which conflict with this change

Contributor

github-actions bot commented Oct 31, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

7 similar comments

Contributor

github-actions bot commented Oct 31, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 1, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 1, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 2, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 2, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 3, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 3, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

htahir1 force-pushed the main branch from ab810a9 to a314637 Compare

November 3, 2022 17:41

Contributor

github-actions bot commented Nov 4, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

13 similar comments

Contributor

github-actions bot commented Nov 4, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 7, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 7, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 8, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 8, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 9, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 9, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 10, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 10, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 11, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 11, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 14, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 14, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 21, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

16 similar comments

Contributor

github-actions bot commented Nov 21, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 22, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 22, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 23, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 23, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 24, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 24, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 25, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 25, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 28, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 28, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 29, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 29, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 30, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Nov 30, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 1, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Collaborator

schustmi commented Dec 1, 2022

Hey @HadiSDev, sorry for the long wait. We're in the process of removing our dependency on the ml-pipelines-sdk library which in turn required lots of other packages. After this is done, updating the pyyaml version and making sure everything still works will be much easier. As your branch is diverged and has many updated files now, I'd ask you to do two things to make this easier:

Rebase your changes on the ZenML develop branch
Update your PR so it merges into the develop branch

This PR should ideally have only a single changed file.

Contributor

github-actions bot commented Dec 1, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

9 similar comments

Contributor

github-actions bot commented Dec 2, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 2, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 5, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 5, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 6, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 6, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 7, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 7, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Contributor

github-actions bot commented Dec 8, 2022

@schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

Collaborator

schustmi commented Dec 8, 2022

Closing this as we can't merge it in the current state, feel free to re-open once it's rebased on develop

schustmi closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment