Test for dashboard_utils
#1202
Merged
Test for dashboard_utils
#1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
internal
safoinme
reviewed
Dec 22, 2022
Comment on lines
+53
to
+56
| if Client().zen_store.type == "rest": | ||
| url = dashboard_utils.get_run_url("test") | ||
| assert url == "https://aria_rules.com/pipelines/all-runs" | ||
| assert isinstance(url, str) |
There was a problem hiding this comment.
This function is meant to test get run URL, can we add another test where the runs list is not empty and the returned URL is actually right for a run name?
There was a problem hiding this comment.
Added an extra test to cover this case. Thanks!
safoinme
approved these changes
Dec 23, 2022
htahir1
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 tests for one of the
dashboard_utilsfunctions.Pre-requisites
Please ensure you have done the following:
Types of changes