Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test typed_model utilities #1208

Merged
merged 5 commits into from Jan 11, 2023
Merged

Test typed_model utilities #1208

merged 5 commits into from Jan 11, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Jan 2, 2023

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added internal To filter out internal PRs and issues tests Test suite additions or updates labels Jan 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

@stefannica, @schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

@stefannica, @schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

@stefannica, @schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

@stefannica, @schustmi
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

@strickvl strickvl requested review from fa9r and removed request for schustmi January 5, 2023 13:44
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

@stefannica, @fa9r
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

@stefannica, @fa9r
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

@stefannica, @fa9r
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

@fa9r
Copy link
Contributor

fa9r commented Jan 9, 2023

What does the BaseTypedModel do exactly? Still not sure I fully get it. Perhaps it could be useful for #1151

@strickvl
Copy link
Contributor Author

strickvl commented Jan 9, 2023

@fa9r Not really sure. @stefannica added it for something he was writing.

@strickvl strickvl merged commit 8da1b23 into develop Jan 11, 2023
@strickvl strickvl deleted the test/ENG-1592-typed-model-utils branch January 11, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannica stefannica stefannica approved these changes

@fa9r fa9r fa9r approved these changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues tests Test suite additions or updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@strickvl @fa9r @stefannica