Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test examples on kubeflow pipelines #667

Closed
wants to merge 159 commits into from

Conversation

AlexejPenner
Copy link
Collaborator

@AlexejPenner AlexejPenner commented May 30, 2022

Describe changes

Running with:
pytest tests/integration/test_examples.py -s --on-kubeflow --use-virtualenv

Will now run the chosen examples on kubeflow. This should manly happen from within the github actions and is less intended for local use.

All examples that rely on a configurable stack component get their secrets from the gh action secret manager. Some examples are still missing from this but should follow in the future (wandb_tracking, whylogs, step operator, cloud_secrets_manager).

These tests will be run when '''LTKF!' has been commented on a PR - on success a comment is left on the PR:

TestingQuo

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels May 30, 2022
@AlexejPenner AlexejPenner changed the base branch from main to develop May 30, 2022 15:31
@AlexejPenner
Copy link
Collaborator Author

LTKF!

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

2 similar comments
@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@github-actions
Copy link
Contributor

Kubeflow tests succeeded! ✅

@schustmi schustmi closed this Aug 17, 2022
@AlexejPenner AlexejPenner deleted the feature/ENG-939-LTKF branch June 20, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants