/
controlplane.go
281 lines (247 loc) · 9.6 KB
/
controlplane.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
package validation
import (
"context"
"fmt"
"net/http"
"github.com/go-logr/logr"
admissionv1beta1 "k8s.io/api/admission/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/runtime/inject"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
maistrav1 "github.com/maistra/istio-operator/pkg/apis/maistra/v1"
maistrav2 "github.com/maistra/istio-operator/pkg/apis/maistra/v2"
"github.com/maistra/istio-operator/pkg/controller/common"
webhookcommon "github.com/maistra/istio-operator/pkg/controller/servicemesh/webhooks/common"
"github.com/maistra/istio-operator/pkg/controller/versions"
)
type ControlPlaneValidator struct {
client client.Client
decoder *admission.Decoder
namespaceFilter webhookcommon.NamespaceFilter
}
func NewControlPlaneValidator(namespaceFilter webhookcommon.NamespaceFilter) *ControlPlaneValidator {
return &ControlPlaneValidator{
namespaceFilter: namespaceFilter,
}
}
var (
_ admission.Handler = (*ControlPlaneValidator)(nil)
_ inject.Client = (*ControlPlaneValidator)(nil)
_ admission.DecoderInjector = (*ControlPlaneValidator)(nil)
)
func (v *ControlPlaneValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
logger := logf.Log.WithName("smcp-validator").
WithValues("ServiceMeshControlPlane", webhookcommon.ToNamespacedName(&req.AdmissionRequest))
// do we care about this object?
if !v.namespaceFilter.Watching(req.Namespace) {
logger.Info(fmt.Sprintf("operator is not watching namespace '%s'", req.Namespace))
return admission.Allowed("")
}
if req.Namespace == common.GetOperatorNamespace() {
return badRequest("service mesh may not be installed in the same project/namespace as the operator")
}
smcpList := &maistrav2.ServiceMeshControlPlaneList{}
err := v.client.List(ctx, smcpList, client.InNamespace(req.Namespace))
if err != nil {
logger.Error(err, "error listing smcp resources")
return admission.Errored(http.StatusInternalServerError, err)
}
// verify single instance per namespace
if (len(smcpList.Items) == 1 && smcpList.Items[0].Name != req.Name) || len(smcpList.Items) > 1 {
return badRequest("only one service mesh may be installed per project/namespace")
}
smcprequest, err := v.decodeRequest(req, logger)
if err != nil {
logger.Error(err, "error decoding admission request")
return admission.Errored(http.StatusBadRequest, err)
} else if smcprequest.New().GetDeletionTimestamp() != nil {
logger.Info("skipping deleted smcp resource")
return admission.Allowed("")
} else if !smcprequest.NewVersion().IsSupported() {
return badRequest(fmt.Sprintf("Only '%v' versions are supported", versions.GetSupportedVersionNames()))
} else if err := v.validateVersion(ctx, smcprequest.New(), smcprequest.NewVersion()); err != nil {
return badRequest(err.Error())
}
if req.AdmissionRequest.Operation == admissionv1beta1.Update {
// verify update
return v.validateUpdate(ctx, smcprequest.OldVersion(), smcprequest.NewVersion(), smcprequest.Old(), smcprequest.New())
}
return v.validateRequest(ctx, req, smcprequest.NewVersion(), smcprequest.New())
}
func (v *ControlPlaneValidator) decodeRequest(req admission.Request, logger logr.Logger) (smcprequest, error) {
switch req.Kind.Version {
case maistrav1.SchemeGroupVersion.Version:
smcp := &maistrav1.ServiceMeshControlPlane{}
err := v.decoder.Decode(req, smcp)
if err != nil {
logger.Error(err, "error decoding admission request")
return nil, err
}
newVersion, err := versions.ParseVersion(smcp.Spec.Version)
if err != nil {
return nil, fmt.Errorf("invalid Version specified; supported versions are: %v", versions.GetSupportedVersions())
}
var oldsmcp *maistrav1.ServiceMeshControlPlane
oldVersion := versions.InvalidVersion
if req.Operation == admissionv1beta1.Update {
oldsmcp = &maistrav1.ServiceMeshControlPlane{}
err = v.decoder.DecodeRaw(req.AdmissionRequest.OldObject, oldsmcp)
if err != nil {
logger.Error(err, "error decoding admission request")
return nil, err
}
oldVersion, err = versions.ParseVersion(oldsmcp.Spec.Version)
if err != nil {
return nil, fmt.Errorf("invalid Version specified; supported versions are: %v", versions.GetSupportedVersions())
}
}
return &smcpv1request{new: smcp, old: oldsmcp, newVersion: newVersion, oldVersion: oldVersion}, nil
case maistrav2.SchemeGroupVersion.Version:
smcp := &maistrav2.ServiceMeshControlPlane{}
err := v.decoder.Decode(req, smcp)
if err != nil {
logger.Error(err, "error decoding admission request")
return nil, err
}
newVersion, err := versions.ParseVersion(smcp.Spec.Version)
if err != nil {
return nil, fmt.Errorf("invalid Version specified; supported versions are: %v", versions.GetSupportedVersions())
}
var oldsmcp *maistrav2.ServiceMeshControlPlane
oldVersion := versions.InvalidVersion
if req.Operation == admissionv1beta1.Update {
oldsmcp = &maistrav2.ServiceMeshControlPlane{}
err = v.decoder.DecodeRaw(req.AdmissionRequest.OldObject, oldsmcp)
if err != nil {
logger.Error(err, "error decoding admission request")
return nil, err
}
oldVersion, err = versions.ParseVersion(oldsmcp.Spec.Version)
if err != nil {
return nil, fmt.Errorf("invalid Version specified; supported versions are: %v", versions.GetSupportedVersions())
}
}
return &smcpv2request{new: smcp, old: oldsmcp, newVersion: newVersion, oldVersion: oldVersion}, nil
default:
return nil, fmt.Errorf("unknown resource type: %s", req.Kind.String())
}
}
func (v *ControlPlaneValidator) validateVersion(ctx context.Context, obj metav1.Object, version versions.Version) error {
switch smcp := obj.(type) {
case *maistrav1.ServiceMeshControlPlane:
return version.Strategy().ValidateV1(ctx, v.client, smcp)
case *maistrav2.ServiceMeshControlPlane:
return version.Strategy().ValidateV2(ctx, v.client, &smcp.ObjectMeta, &smcp.Spec)
default:
return fmt.Errorf("unknown ServiceMeshControlPlane type: %T", smcp)
}
}
func (v *ControlPlaneValidator) validateRequest(ctx context.Context, req admission.Request, version versions.Version, smcp metav1.Object) admission.Response {
return version.Strategy().ValidateRequest(ctx, v.client, req, smcp)
}
func (v *ControlPlaneValidator) validateUpdate(ctx context.Context, oldVersion, newVersion versions.Version, oldObj, newObj metav1.Object) admission.Response {
// The logic used here is that we only verify upgrade/downgrade between adjacent versions
// If an upgrade/downgrade spans multiple versions, the validation for upgrade/downgrade
// between adjacent versions is chained together, e.g. 1.0 -> 1.3, we'd verify
// upgrade from 1.0 -> 1.1, then 1.1 -> 1.2, then 1.2 -> 1.3. If all of those
// were successful, validation succeeds. This approach may breakdown if a feature
// was removed and subsequently reintroduced (e.g. validation from 1.0 -> 1.1
// fails because feature X is no longer supported, but was added back in 1.3).
if oldVersion.Version() < newVersion.Version() {
for version := oldVersion.Version() + 1; version <= newVersion.Version(); version++ {
if err := version.Strategy().ValidateUpgrade(ctx, v.client, newObj); err != nil {
return badRequest(fmt.Sprintf("cannot upgrade control plane from version %s to %s: %s", oldVersion.String(), newVersion.String(), err))
}
}
} else {
for version := oldVersion.Version(); version > newVersion.Version(); version-- {
if err := version.Strategy().ValidateDowngrade(ctx, v.client, newObj); err != nil {
return badRequest(fmt.Sprintf("cannot downgrade control plane from version %s to %s: %s", oldVersion.String(), newVersion.String(), err))
}
}
}
if err := newVersion.Strategy().ValidateUpdate(ctx, v.client, oldObj, newObj); err != nil {
return badRequest(err.Error())
}
return admission.Allowed("")
}
// InjectClient injects the client.
func (v *ControlPlaneValidator) InjectClient(c client.Client) error {
v.client = c
return nil
}
// InjectDecoder injects the decoder.
func (v *ControlPlaneValidator) InjectDecoder(d *admission.Decoder) error {
v.decoder = d
return nil
}
type smcprequest interface {
New() metav1.Object
NewVersion() versions.Version
Old() metav1.Object
OldVersion() versions.Version
}
type smcpv1request struct {
new *maistrav1.ServiceMeshControlPlane
old *maistrav1.ServiceMeshControlPlane
newVersion versions.Version
oldVersion versions.Version
}
var _ smcprequest = (*smcpv1request)(nil)
func (smcp *smcpv1request) New() metav1.Object {
if smcp == nil {
return nil
}
return smcp.new
}
func (smcp *smcpv1request) NewVersion() versions.Version {
if smcp == nil {
return versions.InvalidVersion
}
return smcp.newVersion
}
func (smcp *smcpv1request) Old() metav1.Object {
if smcp == nil {
return nil
}
return smcp.old
}
func (smcp *smcpv1request) OldVersion() versions.Version {
if smcp == nil {
return versions.InvalidVersion
}
return smcp.oldVersion
}
type smcpv2request struct {
new *maistrav2.ServiceMeshControlPlane
old *maistrav2.ServiceMeshControlPlane
newVersion versions.Version
oldVersion versions.Version
}
var _ smcprequest = (*smcpv2request)(nil)
func (smcp *smcpv2request) New() metav1.Object {
if smcp == nil {
return nil
}
return smcp.new
}
func (smcp *smcpv2request) NewVersion() versions.Version {
if smcp == nil {
return versions.InvalidVersion
}
return smcp.newVersion
}
func (smcp *smcpv2request) Old() metav1.Object {
if smcp == nil {
return nil
}
return smcp.old
}
func (smcp *smcpv2request) OldVersion() versions.Version {
if smcp == nil {
return versions.InvalidVersion
}
return smcp.oldVersion
}