Skip to content
This repository has been archived by the owner on Mar 31, 2024. It is now read-only.

Pico SDK No Longer Submodule in TinyUSB #9

Closed
a-gavin opened this issue Jan 26, 2022 · 3 comments
Closed

Pico SDK No Longer Submodule in TinyUSB #9

a-gavin opened this issue Jan 26, 2022 · 3 comments

Comments

@a-gavin
Copy link

a-gavin commented Jan 26, 2022

set(PICO_SDK_PATH ${TOP}/hw/mcu/raspberrypi/pico-sdk)

I realize this project may not be actively maintained, but I just want to point out for others who may also try building from source that TinyUSB no longer includes the Pico SDK as a submodule as of April 2021, breaking the build script for this project.

Only after fiddling with things for a bit did I realize that there are pre-compiled images available for download in the Releases section of the repo. Linking here for reference.

@majbthrd
Copy link
Owner

Ah, with hindsight I think what happened was that when I updated to the latest TinyUSB on Dec 18, 2021 (only a month ago... I didn't realize such a small time qualified as "not actively maintained"), my existing local build still worked despite the April 2021 change that you refer to. I'll look at it when I next get a chance. You could have just used the previous commit (and updated the submodules to use the previous vintage), and all would have been fine.

I don't know what I have to do to make the Releases tab more obvious... do I need to put something in the README.md?

@a-gavin
Copy link
Author

a-gavin commented Jan 26, 2022

Apologies, I meant no offense by that comment. Didn't want to make you feel pressure to fix this 😄

I don't entirely recall but I believe using the previous commit may have worked for me as well. Downloading from the Releases tab certainly did the trick, though.

I actually only found out about the pre-compiled executable through the rp2040-project-template repo, if that goes to show you how trained my brain is to look at Releases. I think an update to the README.md would suffice.

@majbthrd
Copy link
Owner

majbthrd commented Jan 27, 2022

The Dec 2021 update was meant to be a straightforward, low-risk update to keep current with TinyUSB, but I was mistaken! :(

Anyway, I've made two additional commits: one adds to the README.md to point to the Releases, and the other more involved change was adding pico-sdk to the submodules and updating the CMakeList dependencies to work with the latest pico_sdk build process. This should address the issues you raised.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants