Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver is not exist in go < 1.10. #72

Closed
r4sas opened this issue Mar 6, 2019 · 7 comments
Closed

Resolver is not exist in go < 1.10. #72

r4sas opened this issue Mar 6, 2019 · 7 comments

Comments

@r4sas
Copy link
Contributor

r4sas commented Mar 6, 2019

resolver net.Resolver

🤔
inet.go:21: undefined: net.Resolver

$ go version
go version go1.7.4 linux/amd64
@sevospl
Copy link

sevospl commented May 27, 2019

I'm facing the same issue as well.

src/xd/lib/network/inet/inet.go:21: undefined: net.Resolver Makefile:58: recipe for target 'XD' failed

uname -a
Linux raspberrypi 4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l GNU/Linux

go version
go version go1.7.4 linux/arm

Any idea on this?

@l-n-s
Copy link
Contributor

l-n-s commented May 27, 2019

Dependencies

GNU Make
GO 1.6 or higher

Type net.Resolver was added in 1.8, so I guess XD needs to bump go dependency version to 1.8 ?

@majestrate
Copy link
Owner

majestrate commented May 27, 2019 via email

@sevospl
Copy link

sevospl commented May 27, 2019

Awesome, I've upgraded Go to the newest version and I was able to compile this. Thanks :)

@r4sas
Copy link
Contributor Author

r4sas commented May 28, 2019

I think better add vendored version of net package.

@majestrate
Copy link
Owner

we could also do a shim layer too @r4sas if you want to code one up

@l-n-s
Copy link
Contributor

l-n-s commented May 30, 2019

tbh there's no need to, it's a build-time dependency, and most of the users will use prebuilt binaries anyway

@r4sas r4sas closed this as completed Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants