Add time sensitive period splitting #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riods by microseconds.
ebeigarts
reviewed
Apr 2, 2019
ebeigarts
reviewed
Apr 2, 2019
lib/periodic_records/model.rb
Outdated
| @@ -76,6 +76,10 @@ def periodic_dup | |||
| dup | |||
| end | |||
|
|
|||
| def periodic_increment | |||
There was a problem hiding this comment.
maybe we can call this periodic_precision? wdyt?
There was a problem hiding this comment.
Perhaps splitting_step or record_split_step, because it's only used on overlapping record splitting?
ebeigarts
reviewed
Apr 2, 2019
|
@ivarsb can you fix travis? a) downgrade bundler or b) upgrade bundler in travis yml |
|
@ivarsb looks like we need to update bundler in our gemspec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.