Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incr_parse( $unicode_str ) Bug #56

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

DabeDotCom
Copy link
Contributor

The following works under JSON::XS, but was dying with a
malformed JSON string... error under JSON::PP

perl -C -MJSON::PP -E '
say "@{[ %$_ ]}" for JSON::PP->new->incr_parse(<<JSON);
{ "a": "1" }
{ "b": "\N{BULLET}" }
{ "c": "3" }
JSON
'

@charsbar
Copy link
Collaborator

Thanks for your PR, but the test is failing for the older perls. Could you please fix it?

The following works under `JSON::XS`, but was dying with a
`malformed JSON string...` error under `JSON::PP`

```
perl -C -MJSON::PP -E '
say "@{[ %$_ ]}" for JSON::PP->new->incr_parse(<<JSON);
{ "a": "1" }
{ "b": "\N{BULLET}" }
{ "c": "3" }
JSON
'
```
@DabeDotCom
Copy link
Contributor Author

Thanks for your PR, but the test is failing for the older perls. Could you please fix it?

Yeah, I forgot older perls needed use charnames 'full'... Mea culpa

PS: The reason I picked \N{BULLET} in the first place was:

  • A) It was one word
  • and B) It's been around since Unicode 1.0 — expressly because I wanted to support old versions! 🤓

@charsbar charsbar merged commit adf3a9d into makamaka:master Dec 17, 2021
@charsbar
Copy link
Collaborator

Thank you. Shipped 4.07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants