Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT PROPOSAL] Problem with non BigInteger token id in CEP78 & CEP47 (custom contracts) #9

Open
mystraio opened this issue Oct 12, 2023 · 1 comment

Comments

@mystraio
Copy link

  1. SDK functions for CEP47 and CEP78 ONLY support tokens whose token id is of type BigInteger. There are custom contracts on testnet and mainnet whose ID is, for example, of the String type. The SDK should support all contract types - NFTs in contracts.
    I understand the reason why only BigInteger is supported (this is how CEP47 and CEP78 are constructed by default), but if the possibility of creating custom solutions is allowed, the SDK must support them.

  2. Additionally, in the SDK we have a function that returns the sum of all minted NFTs in a specific contract, but there is no function that will return a list or array of all IDs of minted tokens in the contract.

@mystraio
Copy link
Author

Example data from testnet deploy hash: 98ef8fa4e19176b2de440416e7752575db5205e71941ea5f8b6b4fc6205fd592

Below token id is "" - NULL in parsed data, becaouse of non BigInteger Type:

{
"token_id": "",
"recipient": "{"Account":"account-hash-0bda75954faaee4eebb17c503a97b1b05300d241435911d93704d34d25836608"}",
"token_meta": "[{"key":"issuer","value":"01a35887f3962a6A232e8E11fA7D4567B6866D68850974AaD7289Ef287676825F6"},{"key":"network","value":"tniC2HX5yg2yDjMQEcUo1bHa44x9YdZVSqyKox21SDz"},{"key":"status","value":"active"}]"
}

and parsed event from this deploy (token_id is String type):
[
{
"token_id": "77b77c7a6a91f1bfa3710d64bc4d3158010b888bbc913e2d7a7722e02ce0a5d3",
"recipient": "Key::Account(0bda75954faaee4eebb17c503a97b1b05300d241435911d93704d34d25836608)",
"event_type": "cep47_mint_one",
"contract_package_hash": "dbb3284da4e20be62aeb332c653bfa715c7fa1ef6a73393cd36804b382f10d4e"
}
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant