Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/SIGN2-46: i18n #61

Merged
merged 4 commits into from
Apr 20, 2022
Merged

feature/SIGN2-46: i18n #61

merged 4 commits into from
Apr 20, 2022

Conversation

vladimir-gachkovsky
Copy link
Contributor

@vladimir-gachkovsky vladimir-gachkovsky commented Apr 18, 2022 •
edited
Loading

Branch created from feature/SIGN2-30-create-vault-page. I will change base after PR #45 will be merged

piotrwitek
piotrwitek suggested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great looks good, need one fix:

  • lang folder should be at the same level as src

@vladimir-gachkovsky
Copy link
Contributor Author

Great looks good, need one fix:

* lang folder should be at the same level as src

Fixed in commit

@vladimir-gachkovsky vladimir-gachkovsky mentioned this pull request Apr 19, 2022
Closed
piotrwitek
piotrwitek reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved

@piotrwitek piotrwitek merged commit f7845a7 into master Apr 20, 2022
@piotrwitek piotrwitek deleted the feature/SIGN2-46-i18n branch April 20, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrwitek piotrwitek piotrwitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladimir-gachkovsky @piotrwitek