Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Private key/Mnemonic onscreen and enable account recovery using private key/mnemonic on Casper Wallet #1

Closed
ghost opened this issue Jan 19, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Jan 19, 2022

To recover a lost account in the Signer app, a user must import their account using a .PEM file containing the account secret key.
Casper Wallet will continue to support account import by file if only to accommodate users migrating their accounts to Casper Wallet from Signer. The gold standard for account recovery in a web wallet is to use a HD-based recovery phrase. All users new to Casper Wallet will be prompted to generate such a phrase.

Support for secret phrase via CEP72 was originally planned for legacy Signer. Here are the old tickets for reference, which may help to accelerate investigations around technical design for Casper Wallet:
casper-network/ceps#72
casper-ecosystem/signer#92

Onboarding - Recovery Phrase set up
Design: https://www.figma.com/file/mBlqs6l6I2d3ihX80Mswm4/Casper-Signer?node-id=1838%3A7567
As a Casper Wallet user, during onboarding I can generate a new, unique CEP72 mnemonic recovery phrase for my HD key
As a Casper Wallet user, during onboarding I can click on the obfuscated recovery phrase to reveal the words
As a Casper Wallet user, during onboarding I can click a copy button to copy the recovery phrase to my clipboard for one minute
As a Casper Wallet user, during onboarding when I click the copy button a message appears confirming that the phrase is copied to clipboard
As a Casper Wallet user, during onboarding after seeing my recovery phrase I am prompted to verify that i know the phrase by filling in missing words in the sequence.
As a Casper Wallet user, during onboarding, when prompted to Confirm my secret phrase, the Confirm button is disabled until I fill in all of the missing values in the sequence by clicking on the word tags at the top of the screen.
As a Casper Wallet user, during onboarding if I do not enter the right missing values and I click Confirm I will encounter an error message screen prompting me to start over. Clicking the Start over button takes me back to the Confirm Your Secret Phrase screen.
As a Casper Wallet user who selects the right missing values in the Confirm my Secret Phrase step, clicking Confirm will direct me to a confirmation screen indicating that the secret phrase has been generated successfully: "Your secret phrase is confirmed!"
As a Casper Wallet user who has successfully generated a secret phrase for my wallet I will not be prompted to generate a new secret phrase the next time I log in.

Additionally, Signer 2 should support a secret phrase architecture which easily integrates with Ledger. For example Ledger supports a 24 word secret - Signer 2 should do the same.

Recovery phrase retrieval
As a Casper Wallet user, I can view my secret phrase at any time from the Settings menu by clicking on Backup secret phrase
image.png

Recovering your accounts using a recovery phrase
As a Casper Wallet user, during onboarding, if I click the 'I already have a Secret Phrase button' I will be prompted to enter it in an input field.
image.png
image.png
As a Casper Waller user, during onboarding, if I enter an unrecognized recovery phrase into the input field and click 'Confirm', I will encounter an error screen prompting me to start over. Clicking Start Over will direct me one step back to the Recovery Phrase input screen

@ghost ghost added the Epic label Jan 19, 2022
@ghost ghost changed the title As Signer, I use a Mnemonic Phrase for easy key management As Signer, I use a Mnemonic Phrase to simplify key management Jan 20, 2022
@adammake adammake self-assigned this Feb 20, 2022
@adammake adammake changed the title As Signer, I use a Mnemonic Phrase to simplify key management Display Private key/Mnemonic onscreen and enable account recovery using private key/mnemonic on the Casper Signer Mar 24, 2022
@canny
Copy link

canny bot commented Mar 24, 2022

This issue has been linked to a Canny post: Enable account recovery using private key/mnemonic on the Casper Signer 🎉

@piotrwitek piotrwitek self-assigned this Mar 29, 2022
@adammake adammake added this to the CEP72 Support milestone Apr 4, 2022
@adammake adammake changed the title Display Private key/Mnemonic onscreen and enable account recovery using private key/mnemonic on the Casper Signer Display Private key/Mnemonic onscreen and enable account recovery using private key/mnemonic on Casper Wallet Aug 14, 2022
@adammake adammake removed this from the CEP72 Support milestone Sep 6, 2022
@piotrwitek piotrwitek assigned karatnyk and unassigned karatnyk Oct 25, 2022
@piotrwitek piotrwitek added this to the 0.4.1 milestone Oct 25, 2022
@piotrwitek piotrwitek reopened this Oct 28, 2022
@piotrwitek piotrwitek modified the milestones: 0.4.0, 0.3.2 Oct 28, 2022
@karatnyk
Copy link

karatnyk commented Dec 5, 2022

Moving to 'Done' as successfully implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants