Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of tests for rpow (?) #137

Open
yaronvel opened this issue Sep 21, 2020 · 3 comments
Open

lack of tests for rpow (?) #137

yaronvel opened this issue Sep 21, 2020 · 3 comments

Comments

@yaronvel
Copy link
Contributor

rpow is implemented in jug.sol and drip.sol. The function is complex enough to deserve some dedicated tests but I do not find any in the dss repository.

I am guessing the function was first implemented elsewhere and was tested there, and would appreciate if I could get a reference for it.
I am working on a project that integrates with the dss, and needs to duplicate the rpow logic. Hence, a reference for the tests would help me test my code.

@yaronvel
Copy link
Contributor Author

yaronvel commented Oct 3, 2020

added a PR with a basic test for rpow.
#145

@gbalabasquer
Copy link
Contributor

The rpow function is tested via formal verification in https://github.com/makerdao/k-dss.
Anyway thank you very much for your PR, we will look into it.

@yaronvel
Copy link
Contributor Author

yaronvel commented Oct 5, 2020

“Beware of bugs in the above code; I have only proved it correct, not tried it.”

― Donald Knuth

But on a more serious note, i guess klab and dapp test environment relies on the same underlying tools, so it is probably ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants