Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reentrancy detected #56

Closed
L-KH opened this issue Aug 30, 2019 · 1 comment
Closed

Reentrancy detected #56

L-KH opened this issue Aug 30, 2019 · 1 comment

Comments

@L-KH
Copy link

L-KH commented Aug 30, 2019

Reentrancy in Flopper.deal(uint256) (flop.sol#133-139):
External calls:
- gem.mint(bids[id].guy,bids[id].lot) (flop.sol#137)
State variables written after the call(s):
- bids (flop.sol#138)
Reentrancy in Flopper.dent(uint256,uint256,uint256) (flop.sol#117-132):
External calls:
- vat.move(msg.sender,bids[id].guy,bid) (flop.sol#127)
State variables written after the call(s):
- bids (flop.sol#129)
- bids (flop.sol#130)
- bids (flop.sol#131)
Reentrancy in Flopper.yank(uint256) (flop.sol#144-149):
External calls:
- vat.move(address(this),bids[id].guy,bids[id].bid) (flop.sol#147)
State variables written after the call(s):
- bids (flop.sol#148)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#reentrancy-vulnerabilities-1

@livnev
Copy link
Contributor

livnev commented Aug 30, 2019

These are all false positives: the external calls are to known contracts, and there is no possibility of reëntrancy there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants