Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require messages to all require statements. #97

Closed
MicahZoltu opened this issue Nov 7, 2019 · 4 comments
Closed

Add require messages to all require statements. #97

MicahZoltu opened this issue Nov 7, 2019 · 4 comments

Comments

@MicahZoltu
Copy link

Trying to integrate with Maker is proving to be quite the chore because many of the require calls contain no message, which means when a transaction fails it is for an opaque reason. If each of the require statements contained a unique message (even if it was just file/line number) then it would be much easier to debug failures.

@gbalabasquer
Copy link
Contributor

Hey, have you checked the latest version? 6fa5581

@MicahZoltu
Copy link
Author

Ah, sneaky buggers. I was using the version from yesterday.

@MicahZoltu
Copy link
Author

I will re-open if I find any missing after updating to latest.

@gbalabasquer
Copy link
Contributor

There are some missing messages (for internal functions) as that brings issues with the formal verification proofs. Those will remain as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants