Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis checks failed, even though program works #478

Closed
calveym opened this issue Sep 6, 2016 · 2 comments
Closed

Travis checks failed, even though program works #478

calveym opened this issue Sep 6, 2016 · 2 comments

Comments

@calveym
Copy link

calveym commented Sep 6, 2016

#477

There is the repo. Locally, it works, but travis CI says it does not. I think I have my output in a slightly different format to what it is expecting, as I know it works when I try the program from terminal. Does this 100% need to work, or should I move on?

@hanrattyjen
Copy link

hanrattyjen commented Sep 6, 2016

Wondering the same thing! Chapter 9 exercise 1 (ask.rb) has passed but the two roman numerals exercises have failed even though they work from the command line. I even double checked some of my output against the Travis CI build output and they matched, yet showed as failed.

rspec also showed ask.rb and old_school_roman_numerals.rb as passing but wouldn't load roman_numerals.rb. Haven't figured out why yet.

If you haven't figured it out within the hour, I would do as the notes suggest and go onto the next exercise. I think I might do the same :)

ETA: Mine passed now. I had some extra 'puts' methods in there that were unnecessary. Removed in favour of: return "string", so it exits from the loop.

@anitacanita
Copy link
Contributor

@LMCMLJ and @hanrattyjen Please move this issue to the pre_course repo, otherwise it doesn't show on slack!

@calveym calveym closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants