Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a comprehensive tool list #14

Closed
bkamapantula opened this issue May 3, 2021 · 26 comments
Closed

Prepare a comprehensive tool list #14

bkamapantula opened this issue May 3, 2021 · 26 comments
Labels
documentation Improvements or additions to documentation

Comments

@bkamapantula
Copy link
Collaborator

For new labs, we need to identify a comprehensive tool list. Here's a preliminary draft:

https://docs.google.com/spreadsheets/d/1DynT9Mh8jcV9qHxwFuQxj1fcQQHj_v_ymwpoZD1L23g/edit#gid=1782181776

Note: this is posted here from the FAQs sheet post discussion on 2nd May.

Please identify an assignee.

@bkamapantula bkamapantula added the documentation Improvements or additions to documentation label May 4, 2021
@nirmaljeffrey
Copy link

Hey @bkamapantula, Should we need to add more tools apart from the ones in google sheet?
if not, Can I raise a pull request with the tools list mentioned in the google sheet and its corresponding images as markdown file (readme)?

@bkamapantula
Copy link
Collaborator Author

hi @nirmaljeffrey! the list has been expanded since I created the issue. I'll check with the team tonight and share an update here in ~6 hrs

@bkamapantula
Copy link
Collaborator Author

bkamapantula commented May 6, 2021

hi @nirmaljeffrey, the current list is more of a guideline and not necessarily a comprehensive one. Sorry for the late response!

Please go ahead create a PR. We can periodically update it.

@nirmaljeffrey
Copy link

sure @bkamapantula will raise it by today. Can you also please mention the location where I should add this readme file in this repository?

@bkamapantula
Copy link
Collaborator Author

Thanks! Is it possible to add it in the Wiki? Not sure if it's version controlled though.

If it isn't, adding under docs directory should be good. @Anool if not, please suggest otherwise

@nirmaljeffrey
Copy link

https://docs.github.com/en/communities/documenting-your-project-with-wikis/viewing-a-wikis-history-of-changes - github wiki is version controlled. It will be the correct place for adding all these docs that we have in google sheets. @bkamapantula I'm unable to create a wiki. So can you please create a wiki for this repo? , so that I can clone and raise a PR for tools list.

@bkamapantula
Copy link
Collaborator Author

done https://github.com/MakersAsylumIndia/M19_OxiKit/wiki/Lab-tools-list

@nirmaljeffrey
Copy link

nirmaljeffrey commented May 6, 2021

nirmaljeffrey (nirmal/#14-add-lab-tools-list) M19_OxiKit.wiki $ git push --set-upstream origin nirmal/#14-add-lab-tools-list
remote: Permission to MakersAsylumIndia/M19_OxiKit.wiki.git denied to nirmaljeffrey.
fatal: unable to access 'https://github.com/MakersAsylumIndia/M19_OxiKit.wiki.git/': The requested URL returned error: 403

@bkamapantula, I'm unable push my branch to remote. please check. It looks like i dont have permission.

@nirmaljeffrey
Copy link

@bkamapantula, If I don't have the access to the repo, should I need to fork this repo and raise PR?

@bkamapantula
Copy link
Collaborator Author

I think it's a permission issue, I can't add you as a developer (I don't have access).

can you please fork and raise a PR?

@nirmaljeffrey
Copy link

I tried to fork the main repo, but github wiki is treated as seperate repo. So I'm unable to fork the github wiki. A new wiki was created for my forked repository. I have attached the screenshot for the wiki in my forked repository.
Screenshot 2021-05-06 at 2 59 36 PM

@bkamapantula
Copy link
Collaborator Author

i see, please create it in your repo and share the link here, I'll create. for subsequent edits we can use this issue thread.

@nirmaljeffrey
Copy link

I will share the updated markdown file. please add the file to the remote repo. whenever an edit is requested, I will share the updated markdown in this issue thread. is that fine for you @bkamapantula

@nirmaljeffrey
Copy link

Lab-tools-list.md

@bkamapantula
Copy link
Collaborator Author

looks good, thanks @nirmaljeffrey!

@nirmaljeffrey
Copy link

nirmaljeffrey commented May 6, 2021

@bkamapantula in this markdown file, I just copied the items from google sheets. But I didn't do any changes as of now. If I add images, will there any copyright issues? and also If i add links to amazon or flipkart or other online sellers, will there be any problem? Am I allowed to add images and add links?

@bkamapantula
Copy link
Collaborator Author

images and links are fine, no problem.

@nirmaljeffrey
Copy link

Also, it would be great if developer access are given to all and merge access for master branch can be restricted to maintainers. So that everyone can raise PRs. Atleast this will be a problem for people who wants to contribute for wiki.

@bkamapantula
Copy link
Collaborator Author

agreed, @Anool -- please review on the dev access when you get a chance.

Wiki is live: https://github.com/MakersAsylumIndia/M19_OxiKit/wiki/Lab-tools-list

thanks much @nirmaljeffrey!

@nirmaljeffrey
Copy link

@bkamapantula, Glad to help. Ping me if anything is required in git. will spend my free time to contribute to this project.

@Hemant-Git911
Copy link

How to get involved in M19 Initiavite as a FY student Mechanical
@makersasylum

@bkamapantula
Copy link
Collaborator Author

closing this issue as the tool list is live on Wiki.

@bkamapantula
Copy link
Collaborator Author

How to get involved in M19 Initiavite as a FY student Mechanical
@makersasylum

hi @Hemant-Git911, please register your interest with us:

once your details are in, we will reach out on how to get involved. thanks!

@Anool
Copy link
Contributor

Anool commented May 7, 2021

agreed, @Anool -- please review on the dev access when you get a chance.

Wiki is live: https://github.com/MakersAsylumIndia/M19_OxiKit/wiki/Lab-tools-list

thanks much @nirmaljeffrey!

Can I add you folks as "maintainer", or will you need higher access levels?

@nirmaljeffrey
Copy link

nirmaljeffrey commented May 8, 2021

@Anool, it's not required. The problem is with wikis.
Either edit access should be given to everyone or restricted only to maintainers. So I will use this workaround for raising PR for wikis - https://www.growingwiththeweb.com/2016/07/enabling-pull-requests-on-github-wikis.html

@bkamapantula
Copy link
Collaborator Author

yes

for non-wiki contributions, contributors can use the fork + PR approach.

for the Wiki contributions, we could do that or (if it looks complicated to set up) use the Issues + discussion + maintainers adding to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants