Skip to content

Commit

Permalink
update contributing guidelines
Browse files Browse the repository at this point in the history
  • Loading branch information
makeusabrew committed Oct 1, 2013
1 parent f2c485e commit abb3245
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
11 changes: 6 additions & 5 deletions CONTRIBUTING.md
@@ -1,11 +1,12 @@
## Submitting Pull Requests

* run ```npm install``` to make sure your development dependencies are up-to-date
* Please ensure that the test suite passes before submitting a PR:
* ```npm test```
* Please rebase your branch against the current master
* Run ```npm install``` to make sure your development dependencies are up-to-date
* [grunt-cli](https://github.com/gruntjs/grunt-cli) >= 0.4.0 is required to sanity check your contribution
* Please ensure that the test suite passes **and** that bootbox.js is lint free before submitting a PR:
* ```grunt```
* If you've added new functionality, **please** include tests which validate its behaviour
* Please ensure that bootbox.js is lint free:
* ```grunt jshint```
* **Please follow these basic steps to make pull request reviews easier!**

## Submitting bug reports

Expand Down
9 changes: 9 additions & 0 deletions Gruntfile.js
Expand Up @@ -16,9 +16,18 @@ module.exports = function(grunt) {
jshintrc: ".jshintrc"
},
all: ["bootbox.js"]
},

karma: {
unit: {
configFile: "karma.conf.js"
}
}
});

grunt.loadNpmTasks("grunt-contrib-uglify");
grunt.loadNpmTasks("grunt-contrib-jshint");
grunt.loadNpmTasks("grunt-karma");

grunt.registerTask("default", ["jshint", "karma"]);
};
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -28,6 +28,7 @@
"karma-junit-reporter": "~0.1.0",
"sinon": "~1.7.3",
"sinon-chai": "~2.4.0",
"karma-chai": "0.0.1"
"karma-chai": "0.0.1",
"grunt-karma": "~0.6.2"
}
}

0 comments on commit abb3245

Please sign in to comment.