Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display HTTP error after clicking Open In Portal #81

Closed
Jackymancs4 opened this issue Aug 31, 2020 · 1 comment
Closed

Display HTTP error after clicking Open In Portal #81

Jackymancs4 opened this issue Aug 31, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers UI Deals with the visual user interface
Milestone

Comments

@Jackymancs4
Copy link

Hello @makeworld-the-better-one
While trying to diagnose #77 I changed the http config value to something invalid.

After that I forgot to change it back to default, and while navigating some gemini pages I tried to open a png image with the portal option. It silently failed and only after a while I tried to open another http page that correctly prompted the error (which reminded me to fix the config).

So, in summary, if there aren't any technical reasons against it, I think it's a good idea to enable modal responses (both error and info) after a That file could not be displayed. What would you like to do? interaction.

@makew0rld makew0rld added bug Something isn't working UI Deals with the visual user interface labels Aug 31, 2020
@makew0rld makew0rld changed the title Do not suppress error messagges when opening file in portal Display HTTP error after clicking Open In Portal Aug 31, 2020
@makew0rld makew0rld added the good first issue Good for newcomers label Aug 31, 2020
@makew0rld
Copy link
Owner

Thanks for finding this, the error popup should definitely occur in this case as well.

@makew0rld makew0rld added this to the v1.6.0 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers UI Deals with the visual user interface
Projects
None yet
Development

No branches or pull requests

2 participants