XDG config #100
Merged
XDG config #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makew0rld
requested changes
Oct 3, 2020
There was a problem hiding this comment.
Thanks for making this PR!
To fully close #97, could you parse all the XDG variables this way? So replace xdg_cache with checking for basedir.CacheHome, and xdg_data with checking for basedir.DataHome. Thanks! See my other comments below.
config/config.go
Outdated
| @@ -10,6 +10,8 @@ import ( | |||
| "runtime" | |||
| "strings" | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
This fixes a go fmt error. Make sure to run go fmt ./... on your code!
Co-authored-by: makeworld <25111343+makeworld-the-better-one@users.noreply.github.com>
Co-authored-by: makeworld <25111343+makeworld-the-better-one@users.noreply.github.com>
|
Thanks, this looks good! Congrats on being #100 :) |
makew0rld
added a commit
that referenced
this pull request
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #97.