Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use PyTorch for simple machine learning models (linear regression, logistic regression, ...) instead of scikit-learn ? #5

Closed
MohamedLEGH opened this issue Jul 24, 2023 · 1 comment

Comments

@MohamedLEGH
Copy link
Contributor

Hello,
I was curious to know why you implement all the machine learning models in PyTorch instead of another library like scikit-learn ? Is it because it's easier to have all the models implemented in the same way ? Do you have plan to be compatible with other machine library in the future ?

Thanks,
Mohamed Amine

@makgyver
Copy link
Owner

Hi @MohamedLEGH, the main reason for implementing all of them in pytorch is convenience! In particular, the TorchModelHandler class can handle torch models regardless of the architecture. Clearly, if the merge or the update are not the standard ones they have to be changed (see AdaLine and Pegasos). I have no plans in making gossipy compatible with sklearn (or other libraries), however feel free to contribute to gossipy, if you like :)

@makgyver makgyver closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants