Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes units are not handled #3945

Open
3 tasks done
aplavin opened this issue Jun 7, 2024 · 1 comment
Open
3 tasks done

Sometimes units are not handled #3945

aplavin opened this issue Jun 7, 2024 · 1 comment
Labels

Comments

@aplavin
Copy link
Contributor

aplavin commented Jun 7, 2024

I encountered this strange inconsistency:

# works:
julia> scatter([1u"m"], [2])

# works:
julia> scatter([(1, 2)])

# doesn't work:
julia> scatter([(1u"m", 2)])
ERROR: ArgumentError:     Conversion failed for Scatter (With conversion trait PointBased()) with args: Tuple{Vector{Tuple{Quantity{Int64, 𝐋, Unitful.FreeUnits{(m,), 𝐋, nothing}}, Int64}}} .
    Scatter requires to convert to argument types Tuple{AbstractVector{<:Union{Point2, Point3}}}, which convert_arguments didn't succeed in.
    To fix this overload convert_arguments(P, args...) for Scatter or PointBased() and return an object of type Tuple{AbstractVector{<:Union{Point2, Point3}}}.`

I guess it's an omission somewhere in the pipeline? The pipeline is quite involved, so not sure where exactly.

  • are you running newest version (version from docs) ?
  • can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie)
  • What platform + GPU are you on?
@aplavin aplavin added the bug label Jun 7, 2024
@SimonDanisch
Copy link
Member

No, this is expected and discussed in the current limitation in the docs and Blogpost.
Its just much more complicated to handle those cases, and there wasn't much time to implement this feature already ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants