Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module_battle_debug: animation change system #43

Closed
MaKiPL opened this issue Apr 15, 2019 · 3 comments
Closed

module_battle_debug: animation change system #43

MaKiPL opened this issue Apr 15, 2019 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@MaKiPL
Copy link
Owner

MaKiPL commented Apr 15, 2019

there's currently no animation system (they are all playing at constant animation index=0).
Frame[n] holds current frames for every entity, we should implement an animation index change system with animation blending available (new feature)

EDIT: Fix frame[n] for monster and characters due to recent change in instance system

@MaKiPL MaKiPL added the enhancement New feature or request label Apr 15, 2019
@MaKiPL MaKiPL added this to the Battle entity polishing milestone Apr 15, 2019
@MaKiPL MaKiPL self-assigned this Apr 15, 2019
@MaKiPL
Copy link
Owner Author

MaKiPL commented Apr 27, 2019

I'll leave some notes here so I don't forget.
Currently I have frames[n] that hold frames pointers for all instances of battleEntities (monster+weapon+chara). All anims are fixed at 0, therefore there should be a system that:

  1. Takes animation Id and entity pointer (length by monsters + chara + weapon)
  2. Sets the animation Id to some array like frame[n], maybe frame[,]?
  3. Force frame[n] = 0 for specific Id, so the animation doesn't start in the middle.

Thankfully FF8 animations are built so there's no really need for n-animation blending- also they are modular, like the whole Squall attack is actually AFAIR 3 animations, starting run, running, strike start, striking and jumping back. When I was playing with enemy coordinates it looks like the animation origin position is actually calculated by enemy position, therefore if we set enemy behind the Squall, the character would actually run back

@MaKiPL
Copy link
Owner Author

MaKiPL commented Apr 27, 2019

also worth to note that the frame[n] is actually broken after updating the encounters and working on single-instance of debug_battleDat (thanks to that there's no more need to actually read the same monster two, three or even four times saving both: CPU and memory (RAM had to hold 4x the same data in worst case)

@MaKiPL MaKiPL added the bug Something isn't working label Apr 27, 2019
@MaKiPL
Copy link
Owner Author

MaKiPL commented May 4, 2019

Image showing Squall running from battle indicating working animation instance subsystem

@MaKiPL MaKiPL closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant