Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Security Hole? Allows anonymous bind if no password submitted by frontend #164

Open
lhardie opened this issue Sep 9, 2019 · 0 comments
Open

Comments

@lhardie
Copy link

lhardie commented Sep 9, 2019

I have discovered that if the frontend of the application does not send a password parameter at all, the code that checks for an empty password does not catch it, and the user is allowed to authenticate anonymously in the ldap bind.

Is this intended behavior?

If it is not, the problem code is in Security/Authentication/LdapAuthenticationProvider.php:
if ('' === $presentedPassword) {

The above line will not catch when there was no password parameter in the posted data from the frontend.

Therefore, the username provided will be send with an empty password in the ldap bind, and an anonymous authentication will occur.

This relates to this issue: #162 (comment)

I have opened a new issue as I was uncertain at the time that anything was wrong and was worried the issue would not get attention without a more appropriate title.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant