-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar Tkinter error #46
Comments
The master branch of the plugin feature brand new progress bar rewritten from Tix to ttk. It probably require few more touches to eliminate last bugs. Your error seems to be the result of Tkinter not being thread safe, but updating status bar is done with separate thread. I should use Queue object instead. |
Updating progress bar should now be handled in thread safe way. Please test it before I close the issue. |
Sorry for the delay, I was busy and missed the notification about the issue. I still seem to have the same problem on PyMOL 1.6.0 with the latest Dynamics from GitHub. Namely, the exception is thrown and the GUI does not seem to get updated correctly when simulations stop. |
Could you please paste here current error message, as I need to know, which line of code is still not thread safe. Thanks for testing! |
Here you go: Unhandled exception in thread started by
Traceback (most recent call last):
File "/apps/pymol/1.6.0.0-x86_64/modules/pmg_tk/startup/dynamics_pymol_plugin.py", line 1063, in bar_update
root = Tk()
File "/apps/pymol/1.6.0.0-x86_64/ext/lib/python2.7/lib-tk/Tkinter.py", line 1685, in __init__
self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
_tkinter.TclError: out of stack space (infinite loop?) Please let me know if you want me to repeat the test. Cheers! |
Hi, |
Error is gone now. Seems to work fine now. Thanks. I noticed a smell glitch though: if I start calculations and have a fatal error of the calculation setup, which effectively stops the calculations, the start button is still pressed as if they were still running. Also, hitting stop and start again in the same calculation window does not produce the error again as if it does not do anything. I just wanted to highlight that as I do not know if this is an expected behaviour or not. Cheers, Jakub |
I am glad, that we got rid of this pesky bug. I have moved your new observation to #49 . |
Starting a run in PyMol 1.5.0.5 on custom Python 2.7 and Gromacs 4.5.5 on CentOS 6.3 results in the below exception:
The result is that the run continues fine but progress bar is not updated correctly. Also, the buttons next to the progress bar do not change its state (label) at the end.
The text was updated successfully, but these errors were encountered: