Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting tidy() methods for metafor objects to broom #2

Closed
alexpghayes opened this issue Mar 15, 2019 · 7 comments
Closed

Porting tidy() methods for metafor objects to broom #2

alexpghayes opened this issue Mar 15, 2019 · 7 comments

Comments

@alexpghayes
Copy link

People have been asking for these for a while but I haven't implemented them yet! Would you be willing to contribute your code to broom!?

@malcolmbarrett
Copy link
Owner

Yes, definitely. I started this project before it was clear what direction broom was going to go in with all the many models it supported, so I had always thought that might be a possibility. Also going to tag @softloud since this project has been on pause while we look for time to collab

@softloud
Copy link

softloud commented Mar 19, 2019

We so need to get to this - especially with ESH2 coming up. Don't know if either of you are coming?! Anyways, we'll be working on a metaverse:: metapackage there of tidy meta-analysis functions. I can take ideas to the team.

I needed something for my simulation package, so I've been using my crap bespoke functions.

@malcolmbarrett
Copy link
Owner

malcolmbarrett commented Mar 20, 2019

Can you tell us more about that project? Would it be better to port these functions (or merge with yours in metabroom) to metaverse? (is this taking over what we had in mind for metameta?) Depending on the scope of metaverse, it might be better to be a stand-alone package like broom.mixed or otherwise a spot to collaborate on these methods a bit before porting to broom proper?

tidymeta has been working for quite a while, and I set it aside for the sake of collaborating, so it would be nice to put at least parts of it somewhere!

I'm deeply jealous, but I'm afraid that event is a tad far for me ✈️

@softloud
Copy link

Alas, we'll miss you! Well, the opportune time would be now, @malcolmbarrett, to finish this. But I saw you just got married?! People are very keen to have broom functionality at ESH. Will you have any time before April 8?

I'm working remotely and have my simulations under control, so can accommodate any time that works for you.

@malcolmbarrett
Copy link
Owner

I can work on this next week! Let's compare notes offline in the meantime. Looking at metabroom and tidymeta again, I don't think basic coverage for metafor will be a challenge at all

@softloud
Copy link

softloud commented Mar 23, 2019

Excellent are you on the openevisynth slack? If not I can shoot you an invite. Let's do this! This will be an awesome thing to wrap up before ESH, 'cause then they can make use of it for all the proposed projects.


Update - you're there. I've set up a channel so we can drop thoughts and whatnot.

@malcolmbarrett
Copy link
Owner

FYI @alexpghayes, we're working on this over at metabroom. We're making sure it works with most of the many, many models in metafor but will port to a proper broom PR thereafter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants