Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing linking from maliput::drake::analysis to trajectories. #589

Merged

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 21, 2023

🦟 Bug fix

#571 introduced maliput_drake into maliput

Summary

  • This PR adds a missing linking between maliput::drake::analysis and maliput::drake::common::trajectories

Trajectories used but missing linking.

const std::unique_ptr<trajectories::PiecewisePolynomial<T>> traj = integrator_->StopDenseIntegration();

Found out due to:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #589 (aa5510f) into main (d92e42b) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head aa5510f differs from pull request most recent head 6e7d8bc. Consider uploading reports for the commit 6e7d8bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   23.48%   23.45%   -0.03%     
==========================================
  Files         262      262              
  Lines       10386    10386              
  Branches     2920     2920              
==========================================
- Hits         2439     2436       -3     
- Misses       6436     6437       +1     
- Partials     1511     1513       +2     

see 1 file with indirect coverage changes

Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 4a64102 into main Sep 21, 2023
4 checks passed
@francocipollone francocipollone deleted the francocipollone/adds_missing_maliput_drake_link branch September 21, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants