Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes drake from codecov. #599

Merged
merged 3 commits into from Oct 10, 2023

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Summary

  • Drake namespace is a copy-paste from drake repository and therefore we don't have tests for those methods. So, this isn't representative of the code coverage of maliput.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #599 (734f239) into main (65e0571) will increase coverage by 26.89%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #599       +/-   ##
===========================================
+ Coverage   59.18%   86.08%   +26.89%     
===========================================
  Files         350      229      -121     
  Lines       16535    10374     -6161     
===========================================
- Hits         9786     8930      -856     
+ Misses       6749     1444     -5305     

see 579 files with indirect coverage changes

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 515cbbb into main Oct 10, 2023
5 checks passed
@francocipollone francocipollone deleted the francocipollone/exclude_drake_from_codecov branch October 10, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants