Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a base class for RoadGeometry. #21

Merged
merged 2 commits into from Sep 19, 2022

Conversation

agalbachicar
Copy link
Contributor

🎉 New feature

Part of #10

Summary

Adds a base class for RoadGeometry. This PR reduces the numer of LOC in #11. This header file will likely be removed once maliput/maliput#517 is merged as there is no need to provide a custom implementation and we will only need to define in the Builder API the strategy and the sampling step.

Test it

Via automatic tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agalbachicar agalbachicar merged commit 7515f7c into main Sep 19, 2022
@agalbachicar agalbachicar deleted the agalbachicar/#10_road_geometry branch September 19, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants