Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lane::DoEvalMotionDerivatives. #27

Merged
merged 2 commits into from Oct 3, 2022

Conversation

francocipollone
Copy link
Contributor

🎉 New feature

Closes #26

Summary

Implements Lane::DoEvalMotionDerivatives

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

{100., 0., 0.},
{100. + 50 * std::sqrt(2.), 0., 0.},
{100. + 50 * std::sqrt(2.), 2., 0.}} /* srh */,
{{3, 2., 1.}, {3, 2., 1.}, {3, 2., 1.}, {3, 2., 1.}, {3, 2., 1.}} /* expected_motion_derivatives */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the expected motion derivatives are equal to the velocity. The WDot implementation considers the heading dot as zero because of the linea interpolation between the points.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK. It's the cost of a simplified model.

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone force-pushed the francocipollone/eval_motion_derivatives branch from 20f3241 to fe86938 Compare October 3, 2022 15:22
agalbachicar
agalbachicar previously approved these changes Oct 3, 2022
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{100., 0., 0.},
{100. + 50 * std::sqrt(2.), 0., 0.},
{100. + 50 * std::sqrt(2.), 2., 0.}} /* srh */,
{{3, 2., 1.}, {3, 2., 1.}, {3, 2., 1.}, {3, 2., 1.}, {3, 2., 1.}} /* expected_motion_derivatives */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK. It's the cost of a simplified model.

@francocipollone francocipollone merged commit 58b0736 into main Oct 3, 2022
@francocipollone francocipollone deleted the francocipollone/eval_motion_derivatives branch October 3, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement Lane::DoEvalMotionDerivatives
2 participants