Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evolves dependency tag to <depend> for the ignition-gui3 package. #22

Merged
merged 1 commit into from Mar 13, 2023
Merged

Evolves dependency tag to <depend> for the ignition-gui3 package. #22

merged 1 commit into from Mar 13, 2023

Conversation

francocipollone
Copy link
Contributor

🦟 Bug fix

Fixes #21

Summary

Evolves dependency tag to for the ignition-gui3 package.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Evolves dependency tag to <depend> for the ignition-gui3 package.
552cb50 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
agalbachicar
agalbachicar approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit a25539c into main Mar 13, 2023
4 checks passed
@francocipollone francocipollone deleted the francocipollone/fixes_ign_dep branch March 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Maliput - Core development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ign-gui3 dep isn't installed when installing via binaries
3 participants
@francocipollone @j-rivero @agalbachicar