Starts with the translation interface for geometric types. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
This was referenced Dec 29, 2022
Merged
francocipollone
approved these changes
Dec 29, 2022
maliput_ros_translation/include/maliput_ros_translation/convert.h
Outdated
Show resolved
Hide resolved
Comment on lines
+50
to
+69
| maliput_ros_interfaces::msg::BranchPointId ToRosMessage(const maliput::api::BranchPointId& branch_point_id); | ||
| maliput_ros_interfaces::msg::JunctionId ToRosMessage(const maliput::api::JunctionId& junction_id); | ||
| maliput_ros_interfaces::msg::LaneId ToRosMessage(const maliput::api::LaneId& lane_id); | ||
| maliput_ros_interfaces::msg::RoadGeometryId ToRosMessage(const maliput::api::RoadGeometryId& road_geometry_id); | ||
| maliput_ros_interfaces::msg::SegmentId ToRosMessage(const maliput::api::SegmentId& segment_id); | ||
|
|
||
| maliput::api::BranchPointId FromRosMessage(const maliput_ros_interfaces::msg::BranchPointId& branch_point_id); | ||
| maliput::api::JunctionId FromRosMessage(const maliput_ros_interfaces::msg::JunctionId& junction_id); | ||
| maliput::api::LaneId FromRosMessage(const maliput_ros_interfaces::msg::LaneId& lane_id); | ||
| maliput::api::RoadGeometryId FromRosMessage(const maliput_ros_interfaces::msg::RoadGeometryId& road_geometry_id); | ||
| maliput::api::SegmentId FromRosMessage(const maliput_ros_interfaces::msg::SegmentId& segment_id); | ||
|
|
||
| maliput_ros_interfaces::msg::BranchPoint ToRosMessage(const maliput::api::BranchPoint* branch_point); | ||
| maliput_ros_interfaces::msg::Lane ToRosMessage(const maliput::api::Lane* lane); | ||
| maliput_ros_interfaces::msg::LaneEnd ToRosMessage(const maliput::api::LaneEnd& lane_end); | ||
| maliput_ros_interfaces::msg::LaneEndSet ToRosMessage(const maliput::api::LaneEndSet* lane_end_set); | ||
| maliput_ros_interfaces::msg::Junction ToRosMessage(const maliput::api::Junction* junction); | ||
| maliput_ros_interfaces::msg::RoadGeometry ToRosMessage(const maliput::api::RoadGeometry* road_geometry); |
There was a problem hiding this comment.
nit: Missing docstring. It will be a copy-paste as they are pretty similar.
There was a problem hiding this comment.
I made #6 for all that.
maliput_ros_translation/test/maliput_ros_translation/CMakeLists.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
- Provides a package with message descriptions for RoadGeometry, BranchPoint, Junction, Lane and Segment Ids. Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
agalbachicar
force-pushed
the
agalbachicar/#1_add_translation_interface
branch
from
8cc9492
to
25afafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Part of #1
Summary
Part 1 of many that implements the translation interface for all the geometric types. This part provides the code to translate to and from many of the types provided in #3. This PR is missing:
I think that it'll add 200LOC more and this PR is already too big. I'm working on two follow up PRs to address those two things in particular. After that, I'll start working on the node to consume these functions.
Test it
Via unit tests except the things mentioned above.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.