Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where english bruh #22

Closed
ugrolol opened this issue Jul 1, 2020 · 7 comments
Closed

where english bruh #22

ugrolol opened this issue Jul 1, 2020 · 7 comments

Comments

@ugrolol
Copy link

ugrolol commented Jul 1, 2020

image
i was thinking that there no translation but it exist just doesnt work on russian system language

@ugrolol
Copy link
Author

ugrolol commented Jul 1, 2020

image
also ye thing about sorting (its changed on main character list but not in comparison)
physical doesnt fit
also you could make a bit smaller size for comparison table stats too (cos my friend asked about it before cos on lower res phones it doesnt fit so doesnt show numbers)

@MalitsPlus
Copy link
Owner

I switched the primary language of my device to Russian but cannot reproduce this issue. Does your language option don't work on any system language or just Russian?
And thanks for making me notice the font size problem, I will fix this later.

image
image

@ugrolol
Copy link
Author

ugrolol commented Jul 2, 2020

ye it happens on any other language too and on emu device in android studio too
cos when app doesnt find out russian locale (or any other language that doesnt exist) it just use default
i actually thought that you aware about that cos i was annoyed by this from the start and thats why was building my own thing

check there vid https://yadi.sk/i/HSTuT9Wy-ya52g
also there should be problem with wording sometimes like nearest enemy three in my case i just changed order in targetparameter.java i have no idea how cn language works so idk how you can easy change stuff like that for one language without changing whole app
thats reason why i stopped thinking about russian translation cos russians not that smart to use apps in first place and english is more then fine in this case and when you translate its just too complicated
image

i didnt checked text itself
(like im p sure wording in my version maybe better and things like actually noticable )
image

right now basically all changes that i need to make it usable for me
image

@MalitsPlus
Copy link
Owner

Ah, I think I've figured out the reason according to your video capture.
Generally, ShizuruNotes Application will be relaunched after switching language due to this line, but it seems that ShizuruNotes just restarted the Activity in your video.
It works well on my device but I don't know whether there are any permission settings or any other stuffs prevent it relaunching on your device.
For more details your can refer this issue[#14].

@ugrolol
Copy link
Author

ugrolol commented Jul 3, 2020

i mean did you try it on emu?
maybe its just working only on your device as you expected
like what im saying if its working wrong for everyone by default when you not add or change something else then id say its still a bug
i read that issue and issuetracker post got the idea
and just thinking that
when every single person with any language would download app and have exact same problem
they all would need to check same thing again over and over again so basically its a bug

basically as southrop said i just changed implementation to 'androidx.appcompat:appcompat:1.2.0-rc01'
just change appcompat version to anything other then 1.1 and its working fine now

@MalitsPlus
Copy link
Owner

I tried it on my two devices within Android 8 and 10 but emulator. Since there are thousands of customized Android operating systems I have no power to test them all.
And I'm not sure whether there would be any new troubles if I implement a non-stable appcompat so I decided to wait for a stable version.
Btw have you tried
switch language → close app manually → reopen app
I wonder whether language can be switched normally this way.

@ugrolol ugrolol closed this as completed Jul 4, 2020
@ugrolol
Copy link
Author

ugrolol commented Jul 4, 2020

switch language → close app manually → reopen app
yes and that was also in vid i posted above
it doesnt work (cos thats not a problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants