Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week-2 #5

Closed
talalalamdar opened this issue Dec 4, 2017 · 0 comments
Closed

week-2 #5

talalalamdar opened this issue Dec 4, 2017 · 0 comments

Comments

@talalalamdar
Copy link

Hi Mohammad, i have some notes about you code :
1- in step 1 you could have chosen different names for your variables like filteredNumbers and mappedNumbers instead of adding just s
2- in step 3 the request was to filter the tasks that took more than
two hours or more and not less but it is the same concept you just have to change ( < ) with ( >= )
3- you missed the step of summing all durations (how much time in total did she spent)

@malnajar malnajar closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants