Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Native browser corners used on Safari, iPhone, and Firefox 3. #8

Closed
gravis opened this issue Jul 9, 2009 · 7 comments
Closed

Comments

@gravis
Copy link

gravis commented Jul 9, 2009

Hi,

I was using another plugin called corners (yes, same with "s"). I had to drop it in favor of this one, and now my page behaves as expected :)
Anyway, there 2 things I miss in the current implementation :

  • no native corners if safari/firefox (they render a lot better than the JS way)
  • not able to pass "params" as classes. corners is using classes like "rounded {top left}" so that the JS is really minimal (handling the class "corners" only).

It would be great to have these 2 features. Also, I must admin the rendering is a little better on IE with cornerS, but the library also has a lot less features !

ho, corners can be found here :
http://www.atblabs.com/jquery.corners.html

the project doesn't seem to be active any more :(

Thanks

@jasondavies
Copy link

+1 for native corners. See here for information on Mozilla's native support: http://smhill.net/resources/css/rounded_corners/ . I might have a go at this when I get some time.

@malsup
Copy link
Owner

malsup commented Sep 4, 2009

Native rounding support added in v2.00

@gravis
Copy link
Author

gravis commented Sep 8, 2009

You're my hero, thanks a lot Malsup. Let me know if I can vote for you somewhere ;)

@malsup
Copy link
Owner

malsup commented Sep 8, 2009

Just checked in v2.01 which supports the 2nd part of gravis's request - markup driven parameters. See "Using Markup..." example at bottom of: http://www.malsup.com/jquery/corner/

@gravis
Copy link
Author

gravis commented Sep 8, 2009

Sweat. Anyway, this won't work with XHTML doctypes I think ! :(
My 2 cents also, but opera also have some native corners. the syntax is similar to firefox : -opera-border-radius
I really don't care about opera, so nevermind :)

@malsup
Copy link
Owner

malsup commented Sep 8, 2009

It will work fine in XHTML docs, it just won't validate. But it's the HTML5 preferred way of adding metadata:

http://dev.w3.org/html5/spec/Overview.html#embedding-custom-non-visible-data

Anyway, it's there to use or not use - your choice! :-)

@gravis
Copy link
Author

gravis commented Sep 8, 2009

yes, I meant validate :)
Thanks for pointing the html5 doc, I didn't know !

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants